ACK: [PATCH 0/2] [focal/impish/jammy linux-azure] Add sunrpc module parameters for NFSv3 nconnect

[Marcelo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512


Acked-by: Marcelo Henrique Cerri <marcelo.cerri at canonical.com>

I agree with Krzysztof, but at the same time the patch is very well
contained and it keeps the current behavior by default.

Tim Gardner <tim.gardner at canonical.com> writes:

> BugLink: https://bugs.launchpad.net/bugs/1958990
>
> SRU Justification
>
> [Impact]
>
> Microsoft has requested the addition of 2 module parameters to sunrpc.
> The primary purpose of which is to restrict or pin NFSv3 TCP connections
> to one server in order to take advantage of local server connection caching.
> In the presence of a load balancer, round robin connection requests defeats
> the advantages of local caching.
>
> This patch also fixes a race condition when setting RPC message values and
> adding a client connection to the task list. Before, client connections were
> added to the task list before the associated RPC message was fully setup.
>
> With the author's permission I have changed the default value of enable_azure_nconnect
> to false in order to preserve the original logic of this module with the exception
> of the above mentioned race condition.
>
> [Test Plan]
>
> Microsoft tested
>
> [Where things could go wrong]
>
> NFSv3 connection attempts could be slow or fail altogether.
>
> [Other Info]
>
> SF: #00312346


- --
Regards,
Marcelo
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEExJjLjAfVL0XbfEr56e82LoessAkFAmH5kH0ACgkQ6e82Loes
sAmeZgv9G2Houq2q71AXXH1XGQoKujVmFzIHcK/Q9+qsIaaImqo/IqfPMo5S1Do1
C+lIvILUkqLy/IVuGZrjAR5VLsBF2qldXuG/ESxI+c1K4vEUeSikIhv3kKOKARXE
/0Ag+QzOJtr3A9q7w/ImWU3BBG5b5gMBmR03nIKsUGQCwjx//HkV3DnX01HPigJV
wq3OkHaEpsFYfyCddLqvKkxvysRdh8tqU9Z067+nrQK/Ow7eeFESkaHZXM6LSVNc
q819r+GrouCO4tvO7vMDsgT0yuF9XAiKKlL6IEtUrmoRfq7xzjX8J560N75QYNPr
jmQtKV+2oq+F6fFjMn4EtqvFOjcshzqHuA64xx+9dKoLRA2cdXKnetAkI2oLDQ8H
Tta+tXx0gR9r77dDxbhdtbFxcKeNQ4lHpH+RpgvUlnQXpf3YaTJPdyjLbCXbC1iF
pifHafL2yWHJntV8Or7r5oAXyz3buAMcvZR+rnJAt4/eBAOms12rw0GkRifwi14x
YcvzYVyl
=Zijg
-----END PGP SIGNATURE-----