ACK: [PATCH 0/4 V2][SRU][K/J] Fix iosm: WWAN cannot build the connection (DW5823e)

[Tim Gardner]

On 12/2/22 12:20 AM, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1998115
> 
> [Impact]
>    WWAN(DW5823e) can't build the connection successfully.
> 
> [Fix]
>    With INTEL_IOMMU disable config or by forcing intel_iommu=off from
>    grub some of the features of IOSM driver like browsing, flashing &
>    coredump collection is not working.
> 
>    When driver calls DMA API - dma_map_single() for tx transfers. It is
>    resulting in dma mapping error.
> 
>    Set the device DMA addressing capabilities using dma_set_mask() and
>    remove the INTEL_IOMMU dependency in kconfig so that driver follows
>    the platform config either INTEL_IOMMU enable or disable.
> 
>    Because the generic jammy(5.15) doesn't contain NET_DEVLINK and RELAY
>    CONFIGs yet on iosm module, the single patch is necessary for Jammy.
> 
> [Test Case]
>    1. boot up with kernel applied the FIX.
>    2. check the status of wwan by "mmcli -m 0"
>        Status| unlock retries: sim-pin (3)
>              | state: ^[32mconnected^[0m
>              | power state: on
>              | access tech: lte
>              | signal quality: 45% (recent)
>         ----------------------------------
>         3GPP | imei: ######
>              | enabled locks: sim, fixed-dialing
>              | operator id: 46692
>              | operator name: Chunghwa Telecom
>              | registration: home
>              | packet service state: attached
>              | pco:
>              | 0: (complete)
> 
> [Where problems could occur]
> remove the dependency for intel_iommu, iosm would fit better on other platforms not only Intel.
> ~~~
> V2: Fix the error of compilation on other ARCHes.
> * Because riscv64 is enabled on Kinetic, send two CONFIG patches for J/K.
> * Built for Kinetic,
> [200~remote: *** kernel-cbd
> *********************************************************
> remote: * Queueing builds (your 'k_gen_nxt'); ok to interrupt
> remote: * For results:  ssh cbd ls kobako-kinetic-3c4c6e341c87-OpHy
> remote: * 288/576 cores busy (3/6 hosts), 0 builds queued
> remote: 2022-12-02 05:05:15
> kobako-kinetic-3c4c6e341c87-OpHy/amd64/BUILD-OK
> remote: 2022-12-02 05:05:37
> kobako-kinetic-3c4c6e341c87-OpHy/arm64/BUILD-OK
> remote: 2022-12-02 04:59:24
> kobako-kinetic-3c4c6e341c87-OpHy/armhf/BUILD-OK
> remote: 2022-12-02 05:04:16
> kobako-kinetic-3c4c6e341c87-OpHy/ppc64el/BUILD-OK
> remote: 2022-12-02 04:59:40
> kobako-kinetic-3c4c6e341c87-OpHy/s390x/BUILD-OK
> remote:
> ************************************************************************
> 
> Built for Jammy,
> *********************************************************
> remote: * Queueing builds (your 'j_gen_nxt'); ok to interrupt
> remote: * For results:  ssh cbd ls kobako-jammy-c3bfe5915b61-HKLG
> remote: * 0/576 cores busy (0/6 hosts), 0 builds queued
> remote: 2022-12-02 04:17:30  kobako-jammy-c3bfe5915b61-HKLG/amd64/BUILD-OK
> remote: 2022-12-02 04:19:39  kobako-jammy-c3bfe5915b61-HKLG/arm64/BUILD-OK
> remote: 2022-12-02 04:13:31  kobako-jammy-c3bfe5915b61-HKLG/armhf/BUILD-OK
> remote: 2022-12-02 04:18:31  kobako-jammy-c3bfe5915b61-HKLG/ppc64el/BUILD-OK
> remote: 2022-12-02 04:13:11  kobako-jammy-c3bfe5915b61-HKLG/s390x/BUILD-OK
> remote: ************************************************************************
> 
> 
> Koba Ko (1):
>    [K] UBUNTU: [Config] CONFIG_IOSM update annotations on arm64 armhf
>      ppc64el s390x riscv64
> 
> M Chetan Kumar (1):
>    [K] net: wwan: iosm: fix driver not working with INTEL_IOMMU disabled
> 
>   debian.master/config/annotations      | 2 +-
>   drivers/net/wwan/Kconfig              | 2 +-
>   drivers/net/wwan/iosm/iosm_ipc_pcie.c | 7 +++++++
>   3 files changed, 9 insertions(+), 2 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc