[SRU][K][PATCH 0/3] Support LEDs on the SiFive Unmatched

Emil Renner Berthing emil.renner.berthing at canonical.com
Wed Aug 24 11:05:04 UTC 2022


 * The Ubuntu RISC-V kernel carries out-of-tree patches to enable
   the two LEDs on the SiFive Unmatched board.

 * There is now an upstream solution to enable the LEDs that appears
   a little different from userspace. With the out-of-tree patches the
   three colours in the RGB LED appears as 3 different LEDs, but upstream
   models them as 1 RGB LED.

 * Replacing the out-of-tree patches with the upstream solution will
   make Ubuntu kernels behave like the upstream kernel going forward.

[Test Plan]

 * Boot Ubuntu on the Unmatched board and look at how the LEDs show up
   in /sys/class/leds

 * Check that both the green D12 and all three colours of D2 can still
   be controlled from userspace.

[Where problems could occur]

 * Users may have scripts setting up LEDs that will no longer work when
   updating to Kinetic with this change.

Emil Renner Berthing (3):
  dt-bindings: leds: pwm-multicolor: Add active-low property
  leds: pwm-multicolor: Support active-low LEDs
  riscv: dts: sifive unmatched: Add PWM controlled LEDs

 .../bindings/leds/leds-pwm-multicolor.yaml    |  4 ++
 .../boot/dts/sifive/hifive-unmatched-a00.dts  | 42 +++++++++++++++++++
 drivers/leds/rgb/leds-pwm-multicolor.c        |  5 +++
 3 files changed, 51 insertions(+)


More information about the kernel-team mailing list