NAK: [SRU][Jammy:linux-intel-iotg][PATCH 0/2] i915: Enable HuC authentication for EHL, ICL, and ADL-S

[Tim Gardner]

What Stefan said...

Subsequent version descriptions are required in order to keep patch 
review less insane.

On 8/15/22 12:20, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/1981971
> 
> [Impact]
> * In the i915 Intel gfx driver, we need to explicitly enable HuC
>    authentication.
> 
> * This fixes an issue with the Gstreamer media pipeline.
> 
> * This only applies to the ICL, ADL-S, and EHL platforms.
> 
> * This patch is only for the linux-intel-iotg kernel.  We have pulled
>     in patches from upstream, so the state of this driver is in between
>     the upstream 5.15 driver, and the upstream tip-of-tree driver.
> 
> [Test Plan]
> * Intel has tested this patch.
> 
> * I have tested the patch as well.
> 
> * To test, the system is booted, and issuing the command:
>        sudo cat /sys/kernel/debug/dri/0/gt/uc/huc_info
>    will either return the huc info, or it will display
>    "HuC disabled"
> 
> 
> 
> [Where problems could occur]
> * If the installed firmware has been trimmed so that only blobs
>      that were in use were retained, when the kernel tried to load
>      the HuC blob, it would fail.  This scenario should not happen
>      unless someone is mucking about with the installed firmware.
>      If that is the case, other things will likely start failing
>      as well.
> 


-- 
-----------
Tim Gardner
Canonical, Inc