NAK2[J]: [PATCH 0/2][SRU][J][K][OEM-5.14][OEM-5.17] System freeze after resuming from suspend due to PCI ASPM settings

[Timo Aaltonen]

Kai-Heng Feng kirjoitti 22.7.2022 klo 10.30:
> On Wed, Jul 13, 2022 at 5:31 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>>
>> On 08.07.22 04:51, AceLan Kao wrote:
>>> Tim Gardner <tim.gardner at canonical.com> 於 2022年7月7日 週四 晚上9:06寫道：
>>>>
>>>> On 7/6/22 05:40, AceLan Kao wrote:
>>>>> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
>>>>>
>>>>> BugLink: https://bugs.launchpad.net/bugs/1980829
>>>>>
>>>>> [Impact]
>>>>> While doing some tests such as suspend/resume or CPU stress tests the system would hang.
>>>>>
>>>>> [Fix]
>>>>> The 2 commits fix the issue, but still not get accepted yet.
>>>>> https://patchwork.ozlabs.org/project/linux-pci/patch/20220705060014.10050-1-vidyas@nvidia.com/
>>>>> https://patchwork.ozlabs.org/project/linux-pci/patch/20220509073639.2048236-1-kai.heng.feng@canonical.com/
>>>>>
>>>>> [Test]
>>>>> Verified on the failed machines and ODM also verified on their side.
>>>>>
>>>>> [Where problems could occur]
>>>>> The 2 patches look pretty safe to me, they try to preserve the ASPM state of devices.
>>>>>
>>>>> Kai-Heng Feng (1):
>>>>>      PCI:ASPM: Remove pcie_aspm_pm_state_change()
>>>>>
>>>>> Vidya Sagar (1):
>>>>>      PCI/ASPM: Save/restore L1SS Capability for suspend/resume
>>>>>
>>>>>     drivers/pci/pci.c       | 10 +++++--
>>>>>     drivers/pci/pci.h       |  6 ++--
>>>>>     drivers/pci/pcie/aspm.c | 63 ++++++++++++++++++++++++++++-------------
>>>>>     3 files changed, 55 insertions(+), 24 deletions(-)
>>>>>
>>>>
>>>> "PCI/ASPM: Save/restore L1SS Capability for suspend/resume" has been
>>>> reverted in linux-next.
>>> The revision I submitted for SRU is v2 which was submitted to upstream
>>> at July 5, 2022
>>> The reverted one is an old patch which just has the same subject as this one.
>>>
>>
>> No, I cannot believe that. Patch #1 has exactly the same diffstat and from
>> glancing at the exact same commit message except from a different patchworks
>> reference as the patch which got applied and reverted in v5.11 development. And
>> it still has not appeared on linux-next. I cannot speak for Kinectic but for
>> Jammy this is not SRU material. If this gets upstream (linux-next) then please
>> re-submit.
> 
> The regression is no longer observed as the original reporter confirmed:
> https://lore.kernel.org/linux-pci/2ff87bc9-2061-d0c-8cdf-13266a6b1343@panix.com/
> 
> Though it hasn't been merged, this patch crucial for _all_ PCie device
> to function after system resume.
> 
> Kai-Heng

ping, we need this resolved in the jammy kernel, for the next cycle at least


-- 
t