ACK: [SRU][J][master-next][PATCH] UBUNTU: SAUCE: overlayfs: remove CONFIG_AUFS_FS dependency

[Alexander Mikhalitsyn]

On Wed, 3 Aug 2022 16:51:01 +0200
Andrea Righi <andrea.righi at canonical.com> wrote:

> On Wed, Aug 03, 2022 at 02:43:43PM +0300, Alexander Mikhalitsyn wrote:
> > On Wed, 3 Aug 2022 09:24:17 +0200
> > Stefan Bader <stefan.bader at canonical.com> wrote:
> > 
> > > On 03.08.22 08:04, Andrea Righi wrote:
> > > > On Tue, Aug 02, 2022 at 04:35:36PM +0300, Alexander Mikhalitsyn wrote:
> > > > ...
> > > >>>
> > > >>> Yes, I mean focal/hwe-5.15 (that is derived from jammy/linux) and ok, no
> > > >>> rush to have the focal patch, I was just pointing out that we need to
> > > >>> fix also this kernel to make everything aligned/consistent.
> > > >>
> > > >> Sure, I'm ready to prepare patches for all supported kernels. But I will need some guidance from you guys regarding the list of proper branches/git repositories :)
> > > > 
> > > > Alright, after all the clarifications I change my NACK to an ACK:
> > > 
> > > Sorry with the amount of things incoming this does not fly well. It it better to 
> > > resubmit as "[SRU K/J v2] ...". The branch is not necessary. More important here 
> > > are the target kernel names and if that is omitted it is the primary "linux" source.
> > > jammy:linux-hwe-5.17 is only needed separately because it has no parent (but is 
> > > the parent of all 5.17 based kernels). Any other HWE kernels normally are 
> > > derived from a primary kernel. So they inherit the changes automatically.
> > 
> > Dear friends,
> > 
> > I've rechecked different kernels and this is full summary:
> > 
> > ============================
> > 
> > * jammy/linux
> > - hwe-5.17
> > * kinetic/linux
> > - master-next
> > 
> > these branches has no aufs, so we need to port one aufs patch + one fix patch.
> > I've already sent that as a series:
> > [SRU][J][hwe-5.17][PATCH 0/2] UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files
> > 
> > will resent with clear branches indication
> > 
> > ============================
> > 
> > * jammy/linux
> > - master / master-next
> > 
> > aufs is present, all that we need to remove excess IS_ENABLED(CONFIG_AUFS_FS) check
> > in fs/overlayfs/file.c. I've sent this change as:
> > [SRU][J][master-next][PATCH] UBUNTU: SAUCE: overlayfs: remove CONFIG_AUFS_FS dependency
> > 
> > ============================
> > 
> > * kinetic/linux
> > - master
> > * focal/linux
> > hwe-5.15-next
> > hwe-5.13-next
> > 
> > aufs is present, but we have no fix commit here at all. Will send.
> > 
> > ============================
> > 
> > Regards,
> > Alex
> 
> Thanks Alex,

Hi Andrea,

> 
> keep in mind that we don't need special fixes for hwe-5.15 or hwe-5.13,
> because these kernels are derived from other non-hwe kernels
> (specifically jammy/linux and impish/linux), so they will automatically
> get the fixes from their parent.
> 
> Then there's hwe-5.17 that is (unfortunately) a special case, it started
> as a derived kernel (from linux-unstable 5.17), and now it's detached
> from linux-unstable, so it's a standalone kernel and it doesn't have a
> parent anymore.

Thanks for clarifying!

> 
> To summarize I think all we need is the fixes for:
>  - kinetic/linux

[SRU][kinetic:master][focal:hwe-5.13-next/hwe-5.15-next][PATCH] UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files 

>  - jammy/linux

[SRU][J][master-next][PATCH] UBUNTU: SAUCE: overlayfs: remove CONFIG_AUFS_FS dependency

>  - jammy/hwe-5.17

[SRU v2][jammy:hwe-5.17][kinetic:master-next][PATCH 0/2] UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files

OK, then I think that's all from my side because I've sent all the patches.

Please, let me know if any problems appear. I'm also ready to test and verify proposed experimental kernel builds.

Regards,
Alex

> 
> Thanks,
> -Andrea