[SRU][J/K][PATCH 0/1] ioam6.sh selftests fails with 5.15 kernels in Focal
Kleber Sacilotto de Souza
kleber.souza at canonical.com
Tue Aug 2 16:59:31 UTC 2022
BugLink: https://bugs.launchpad.net/bugs/1982930
[Impact]
Testcase ubuntu_kernel_selftests.net:ioam6.sh fails in Focal with the 5.15
kernels with the following errors:
17:19:35 DEBUG| [stdout] make: Entering directory '/tmp/autopkgtest.WSxPqj/build.GQs/src/autotest/cl
ient/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net'
17:19:35 DEBUG| [stdout] make --no-builtin-rules ARCH=x86 -C ../../../.. headers_install
17:19:35 DEBUG| [stdout] make[1]: Entering directory '/tmp/autopkgtest.WSxPqj/build.GQs/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
17:19:35 DEBUG| [stdout] INSTALL ./usr/include
17:19:35 DEBUG| [stdout] make[1]: Leaving directory '/tmp/autopkgtest.WSxPqj/build.GQs/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
17:19:35 DEBUG| [stdout] TAP version 13
17:19:35 DEBUG| [stdout] 1..1
17:19:35 DEBUG| [stdout] # selftests: net: ioam6.sh
17:19:35 DEBUG| [stdout] # SKIP: iproute2 too old, missing ioam command
17:19:35 DEBUG| [stdout] not ok 1 selftests: net: ioam6.sh # exit=1
This is caused by an older version of iproute2 in Focal. The package has been
updated in Jammy via bug 1951390 and the bug report says it should be updated in
Focal as well. Even if the package is eventually updated, the testcase shouldn't
throw a fatal error in this case and really return "SKIP" as the log message
says.
[Fix]
The proper fix would be to make tools/testing/selftests/net/ioam6.sh return the
Kselftest framework proper skip code instead of failing.
[Testcase]
Run the selftest script in Focal with a 5.15 kernel.
[Where problems could occur]
If the skip code is added to places where it shouldn't be added it could
introduce false positives and not fail where it should.
Kleber Sacilotto de Souza (1):
selftests: net: fix IOAM test skip return code
tools/testing/selftests/net/ioam6.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
--
2.34.1
More information about the kernel-team
mailing list