ACK: [SRU] [J] [PATCH 00/10] Additional fix for TGL + AUO panel flickering

Tim Gardner tim.gardner at canonical.com
Tue Aug 2 12:46:32 UTC 2022


On 8/1/22 20:29, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1983297
> 
> [Impact]
> "UBUNTU: SAUCE: drm/i915/display/psr: Fix flicker on TGL + AUO panel"
> alone used to fix the issue on the AUO panel. But the panel starts to
> flicker like crazy on top of the new stable commits.
> 
> [Fix]
> Backport full fix for PSR2 selective fetch, but only enable it on TGL +
> specific AUO panel. The last three patches which enable PSR2 on ADL-P
> are dropped.
> 
> [Test]
> Originally the backport regressed ADL + BOE panel, so this time we
> put extra effort to ensure those system are unaffected, while TGL + AUO
> panel is still fixed.
> 
> [Where problems could occur]
> Most code changes only have functional impact when PSR2 selective fetch
> is enabled. Some of changes are under more general call path for
> hardware cursor rendering.
> 
> Notes are added to describe the functional impact for each patch, so if
> regression really occurrs it's easier to spot the offending commit.
> 
> 
> Gwan-gyeong Mun (1):
>    drm/i915/display/psr: Do full fetch when handling multi-planar formats
> 
> José Roberto de Souza (7):
>    drm/i915/display: Fix sel fetch plane offset calculation
>    drm/i915: Nuke ORIGIN_GTT
>    drm/i915/display: Drop PSR support from HSW and BDW
>    drm/i915/display/psr: Handle plane and pipe restrictions at every page
>      flip
>    drm/i915/display: Drop unnecessary frontbuffer flushes
>    drm/i915/display: Handle frontbuffer rendering when PSR2 selective
>      fetch is enabled
>    drm/i915/display: Fix glitches when moving cursor with PSR2 selective
>      fetch enabled
> 
> Kai-Heng Feng (2):
>    Revert "UBUNTU: SAUCE: drm/i915/display/psr: Fix flicker on TGL + AUO
>      panel"
>    UBUNTU: SAUCE: drm/i915/display/psr: Reinstate fix for TGL + AUO panel
>      flicker
> 
>   drivers/gpu/drm/i915/display/intel_cursor.c   |   5 +-
>   drivers/gpu/drm/i915/display/intel_display.c  |   3 -
>   drivers/gpu/drm/i915/display/intel_fbc.c      |  12 +-
>   drivers/gpu/drm/i915/display/intel_fbdev.c    |   2 -
>   .../gpu/drm/i915/display/intel_frontbuffer.h  |   4 +-
>   drivers/gpu/drm/i915/display/intel_psr.c      | 223 ++++++++----------
>   drivers/gpu/drm/i915/i915_drv.h               |   2 -
>   drivers/gpu/drm/i915/i915_irq.c               |  16 --
>   drivers/gpu/drm/i915/i915_pci.c               |   4 +-
>   drivers/gpu/drm/i915/i915_reg.h               |  21 +-
>   10 files changed, 109 insertions(+), 183 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list