NACK: [SRU][J][master-next][PATCH] UBUNTU: SAUCE: overlayfs: remove CONFIG_AUFS_FS dependency

Andrea Righi andrea.righi at canonical.com
Tue Aug 2 07:05:31 UTC 2022


On Tue, Aug 02, 2022 at 12:50:43AM +0300, Alexander Mikhalitsyn wrote:
> BugLink: https://bugs.launchpad.net/bugs/1967924
> BugLink: https://bugs.launchpad.net/bugs/1857257
> 
> BugLink: https://bugs.launchpad.net/bugs/1967924
> 
> Right now we have a fix:
> b07bc17b ("UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files")
> in master branch of Jammy kernel, but only formaly. Because these kernels compiled without
> CONFIG_AUFS_FS set, so this fix just disabled. There is no need to make it dependent on
> CONFIG_AUFS_FS option, because in all cases we have mm/prfile.c compiled-in.
> 
> Cc: Andrei Vagin <avagin at gmail.com>
> Cc: Adrian Reber <areber at redhat.com>
> Cc: Stefan Bader <stefan.bader at canonical.com>
> Cc: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Cc: Andrea Righi <andrea.righi at canonical.com>
> 
> Fixes: b07bc17b ("UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files")
> Signed-off-by: Alexander Mikhalitsyn <alexander.mikhalitsyn at virtuozzo.com>

It's true that we don't need this in Jammy, but we need it in focal for
the hwe kernels, where we still need to support AUFS. So, we decided to
keep it also in Jammy, even if, as you correctly mentioned, it's just
formal change, since this patch is a no-op with AUFS disabled, but it
helps to maintain the code especially when we need to release new hwe
kernels.

-Andrea



More information about the kernel-team mailing list