ACK+CMT: [SRU v1][F:linux-bluefield][Pull Request] mlxbf-gige: sync up with upstreamed version

Tue Apr 19 19:09:53 UTC 2022

Hi Luke,

@Vladimir Sokolovsky<mailto:vlad at nvidia.com> and @Orsan Awwad<mailto:oawwad at nvidia.com> informed me that this pull request broke the build because acpi_dev_gpio_irq_get_by is not supported on kernel 5.4.60 and older. But I see that Zachary Tahenakos pushed a change today which adds support to acpi_dev_gpio_irq_get_by in master-next as shown below:

https://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-bluefield/+git/focal/log/?h=master-next
commit
b2be125b1a973468c1e28bb0e076f05cd8fb13a3<https://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-bluefield/+git/focal/commit/?h=master-next&id=b2be125b1a973468c1e28bb0e076f05cd8fb13a3>

So I think we should be all set then?

Thanks.
Asmaa
From: Luke Nowakowski-Krijger <luke.nowakowskikrijger at canonical.com>
Sent: Friday, April 15, 2022 5:21 PM
To: Asmaa Mnebhi <asmaa at nvidia.com>
Cc: Ubuntu Kernel Team <kernel-team at lists.ubuntu.com>
Subject: ACK+CMT: [SRU v1][F:linux-bluefield][Pull Request] mlxbf-gige: sync up with upstreamed version

The only thing I would say needs to be added is UBUNTU: SAUCE to the Revert patches, but I can add that when applying.

This patchset comes just in time as our certification team is finding issues with oob_net0 interface not appearing. We will respin with these fixes.

Acked by: Luke Nowakowski-Krijger <luke.nowakowskikrijger at canonical.com<mailto:luke.nowakowskikrijger at canonical.com>>

On Fri, Apr 15, 2022 at 11:46 AM Asmaa Mnebhi <asmaa at nvidia.com<mailto:asmaa at nvidia.com>> wrote:
BugLink: https://bugs.launchpad.net/bugs/1969233<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F1969233&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=sxDGNOX0xNL7eBRjqHZavo%2B27mNvD1dvh8LEjtUsliA%3D&reserved=0>

The mlxbf-gige driver is currently broken in the latest SRU kernel due to this pull request:
https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds/+merge/417771<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.launchpad.net%2F~asmaam%2Fubuntu%2F%2Bsource%2Flinux-bluefield%2F%2Bgit%2Fversion-seeds%2F%2Bmerge%2F417771&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=co2dFJFuo1egiKoWsB%2FuI%2Fd7NgRHr2mUGr4DTb0a9f4%3D&reserved=0>

The mlxbf-gige driver is dependent and hence needs to be in sync with the gpio-mlxbf.c driver.
So we need to cherry-pick the corresponding changes from upstream.

This pull request (12 commits) includes reverting 6 mlxbf-gige commits in linux-bluefield.
Then it cherry-picks the following 2 commits:
6c2a6ddca763271fa583e22bce10c2805c1ea9f6
ee8a9600b5391f434905c46bec7f77d34505083e

This pull request page can be found at:
https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds/+merge/419560<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.launchpad.net%2F~asmaam%2Fubuntu%2F%2Bsource%2Flinux-bluefield%2F%2Bgit%2Fversion-seeds%2F%2Bmerge%2F419560&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3poJhFxbUF5G%2Fxu5bUYarXfJfMK0th4S9Gc9fm8kTh8%3D&reserved=0>

Git repo can be found at:
git+ssh://asmaam@git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield:master-next-oob-upstream<https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fasmaam%40git.launchpad.net%2F~asmaam%2Fubuntu%2F%2Bsource%2Flinux-bluefield%3Amaster-next-oob-upstream&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=PwJhvqVXXIBsBE5EM%2FfbnTtnaTqlJBMi%2BHGYnL6D4wc%3D&reserved=0>

The following changes since commit 2d4b3a849f7ffbd96e7a158740f56d5bae6bbda0:

  UBUNTU: Ubuntu-bluefield-5.4.0-1034.37 (2022-04-12 13:57:07 -0700)

are available in the Git repository at:

  https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds/+ref/master-next-oob-upstream/+register-merge<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.launchpad.net%2F~asmaam%2Fubuntu%2F%2Bsource%2Flinux-bluefield%2F%2Bgit%2Fversion-seeds%2F%2Bref%2Fmaster-next-oob-upstream%2F%2Bregister-merge&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BrwRn8AFyZrqcAZcTzoQUn%2B6TFiofWs6t7bI05xQRos%3D&reserved=0> 0a6f2617d0c98b2ef042da4ca98f765c9a163bdd

for you to fetch changes up to 0a6f2617d0c98b2ef042da4ca98f765c9a163bdd:

  UBUNTU: SAUCE: Fix OOB handling RX packets in heavy traffic (2022-04-15 13:43:25 -0400)

Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com<mailto:asmaa at nvidia.com>>

Asmaa Mnebhi (11):
  Revert "UBUNTU: SAUCE: Fix OOB handling RX packets in heavy traffic"
  Revert "UBUNTU: SAUCE: mlxbf_gige: update driver version to 1.25"
  Revert "UBUNTU: SAUCE: mlxbf_gige: clear valid_polarity upon open"
  Revert "UBUNTU: SAUCE: mlxbf_gige: add interrupt counts to "ethtool
    -S""
  Revert "UBUNTU: SAUCE: mlxbf-gige: add ethtool
    mlxbf_gige_set_ringparam"
  Revert "UBUNTU: SAUCE: mlxbf-gige: add driver version"
  net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
  UBUNTU: SAUCE: mlxbf-gige: add driver version
  UBUNTU: SAUCE: mlxbf_gige: add interrupt counts to "ethtool -S"
  UBUNTU: SAUCE: mlxbf-gige: add ethtool mlxbf_gige_set_ringparam
  UBUNTU: SAUCE: Fix OOB handling RX packets in heavy traffic

David Thompson (1):
  mlxbf_gige: clear valid_polarity upon open

 .../net/ethernet/mellanox/mlxbf_gige/Makefile |   1 -
 .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |  12 -
 .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c     | 212 ------------------
 .../mellanox/mlxbf_gige/mlxbf_gige_main.c     |  24 +-
 4 files changed, 10 insertions(+), 239 deletions(-)
 delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c

--
2.30.1

--
kernel-team mailing list
kernel-team at lists.ubuntu.com<mailto:kernel-team at lists.ubuntu.com>
https://lists.ubuntu.com/mailman/listinfo/kernel-team<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.ubuntu.com%2Fmailman%2Flistinfo%2Fkernel-team&data=04%7C01%7Casmaa%40nvidia.com%7Ce29e0fe5b2624cb0da0e08da1f25ee63%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637856545020002118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=I0jasUGsYLQHf4hYG%2BjOeN4nwFKlI37kRtpyi8dmJwU%3D&reserved=0>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220419/9a3a4182/attachment-0001.html>