ACK: [SRU][focal:linux-bluefield][PATCH 0/1] linux-bluefield: Fix

Luke Nowakowski-Krijger luke.nowakowskikrijger at canonical.com
Mon Apr 18 18:29:38 UTC 2022


LGTM

Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger at canonical.com>

On Mon, Apr 18, 2022 at 11:25 AM Zachary Tahenakos <
zachary.tahenakos at canonical.com> wrote:

> https://bugs.launchpad.net/bugs/1969374
>
> SRU Justification
>
> [Impact]
>
> The latest PR to fix a certification issue has introduced a build failure.
> Specifically:
> net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
>
> A build of the kernel fails with the following error:
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:380:12: error:
> implicit declaration of function 'acpi_dev_gpio_irq_get_by'; did you mean
> 'acpi_dev_gpio_irq_get'? [-Werror=implicit-function-declaration]
>
> [Fix]
> Cherry-picking:
> 809390219fb9c gpiolib: acpi: Allow to find GpioInt() resource by name and
> index
>
> The above commit reworks GpioInt() to allow finding the resource via name
> and index while preserving previous functionality.
>
> [Test Case]
> Beyond ensuring build still works, no testing of drivers using the
> reworked acpi_dev_gpio_irq_get function will be done, but it should still
> work as previously designed when NULL is passed for name.
>
> [Where problems could occur]
> Chance of regression should be very low with this change.
>
> Andy Shevchenko (1):
>   gpiolib: acpi: Allow to find GpioInt() resource by name and index
>
>  drivers/gpio/gpiolib-acpi.c | 12 ++++++++----
>  include/linux/acpi.h        | 10 ++++++++--
>  2 files changed, 16 insertions(+), 6 deletions(-)
>
> --
> 2.25.1
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220418/51d48bcf/attachment.html>


More information about the kernel-team mailing list