NACK Re: [PATCH][SRU][OEM-5.14] Fix s0i3 entry errors for AMD platforms

Timo Aaltonen tjaalton at ubuntu.com
Thu Sep 30 14:14:18 UTC 2021


On 24.9.2021 4.00, Alex Hung wrote:
>    BugLink: https://bugs.launchpad.net/bugs/1943633
> 
> [Impact]
> 
>    amd-pmc times out communicating with the SMU over stress testing cycles like:
>     > amd_pmc AMDI0005:00: SMU response timed out
>     > amd_pmc AMDI0005:00: failed to talk to SMU
>     > amd_pmc AMDI0005:00: suspend failed
>     > PM: dpm_run_callback(): acpi_subsys_suspend_noirq+0x0/0x50 returns -110
> 
> [Fix]
> 
>    Increase the timeout to 2000ms that matches to GPU driver.
> 
> [Test]
> 
>    This is requested by AMD.
> 
> [Where problems could occur]
> 
>    Low risk. This only affects small number of AMD systems that would excess the
>    original timeout with low fail rate 0.9%-1.7%. In worst case scenario it would
>    only takes time up to 2 seconds.
> 
> Mario Limonciello (1):
>    platform/x86: amd-pmc: Increase the response register timeout
> 
>   drivers/platform/x86/amd-pmc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

this got applied via 5.14.9

-- 
t



More information about the kernel-team mailing list