APPLIED[F]: [F/H/I/Unstable][OEM-5.10/OEM-5.13/OEM-5.14][SRU][PATCH 0/1] selftests/net: remove min gso test in packet_snd

Kelsey Skunberg kelsey.skunberg at canonical.com
Thu Sep 23 22:52:52 UTC 2021


Applied to Focal master-next. Thank you!

-Kelsey

On 2021-09-08 11:58:02 , Po-Hsu Lin wrote:
> [Impact]
> The expected to fail 'raw gso min size - 1' test in psock_snd.sh is
> not failing as expected, and thus this test will fail with:
> 
>   raw gso min size - 1 (expected to fail)
>   tx: 1524
>   rx: 1472
>   OK
> 
> This is because after commit 7c6d2ec ("net: be more gentle about silly
> gso requests coming from user"), we relaxed the min gso_size check in
> virtio_net_hdr_to_skb().
> 
> So when a packet which is smaller then the gso_size, GSO for this
> packet will not be set, the packet will be send/recv successfully.
> 
> [Fix]
> * cfba3fb68960b4 selftests/net: remove min gso test in packet_snd
> 
> This patch can be cherry-picked into all affected kernels.
> 
> I decided to skip those 5.8 variants, as the current cycle
> (2021-09-06) might be the last cycle for them.
> 
> [Test]
> Run this psock_snd.sh script, this test will no longer exist and the
> script can proceed with the next test.
> 
> [Where problems could occur]
> Removing this broken test should not have any negative impact to our
> tests. We will need to update our hints later.
> 
> Dust Li (1):
>   selftests/net: remove min gso test in packet_snd
> 
>  tools/testing/selftests/net/psock_snd.sh | 3 ---
>  1 file changed, 3 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list