APPLIED [OEM-5.14] Re: [PATCH 0/5][SRU][OEM-5.14][U] Fix Cirrus CS8409 pop noise at rebooting

Timo Aaltonen tjaalton at ubuntu.com
Fri Sep 17 13:43:33 UTC 2021


On 3.9.2021 11.45, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1942043
> 
> [Impact]
> 
> HD-audio codec shutdown is not quite right when powering off the
> controller side. This causes pop noises on some platforms.
> 
> [Fix]
> 
> While previously in bug 1939541, a local fix for Cirrus CS8409 only is
> proposed the upstream as in
> https://lore.kernel.org/lkml/20210812183433.6330-2-vitalyr@opensource.cirrus.com/
> . This initiated a discuss to create a generic solution as in
> https://lore.kernel.org/all/20210813081230.4268-1-tiwai@suse.de/ .
> 
> [Test Case]
> 
> Shutdown Ubuntu that is running a patched kernel and see if a pop sound
> is still made.
> 
> [Where problems could occur]
> 
> While this tries to suspend the codec devices at shutting down, out of
> tree drivers without (runtime-)suspend support may fail to react
> correctly. And since this removes .reboot_notify callback from struct
> hda_codec_ops, it may break such oot drivers, too.
> 
> [Other Info]
> 
> This depends on patches for https://bugs.launchpad.net/bugs/1939541 .
> 
> Takashi Iwai (4):
>    ALSA: hda: conexant: Turn off EAPD at suspend, too
>    ALSA: hda: Suspend codec at shutdown
>    ALSA: hda: Nuke unused reboot_notify callback
>    ALSA: hda: Disable runtime resume at shutdown
> 
> You-Sheng Yang (1):
>    Revert "UBUNTU: SAUCE: ALSA: hda/cs8409: Prevent pops and clicks
>      during reboot"
> 
>   include/sound/hda_codec.h      |  1 -
>   sound/pci/hda/hda_bind.c       |  8 +----
>   sound/pci/hda/hda_codec.c      | 12 ++++++++
>   sound/pci/hda/hda_generic.c    | 19 ------------
>   sound/pci/hda/hda_generic.h    |  1 -
>   sound/pci/hda/hda_local.h      |  2 ++
>   sound/pci/hda/patch_analog.c   |  1 -
>   sound/pci/hda/patch_ca0132.c   |  6 ----
>   sound/pci/hda/patch_conexant.c | 15 ++++++---
>   sound/pci/hda/patch_cs8409.c   | 56 +++++++++++++++-------------------
>   sound/pci/hda/patch_realtek.c  | 13 --------
>   sound/pci/hda/patch_sigmatel.c |  1 -
>   12 files changed, 50 insertions(+), 85 deletions(-)
> 

applied to oem-5.14, thanks

-- 
t



More information about the kernel-team mailing list