ACK/cmt: [PATCH 0/2][SRU][OEM-5.14] UBUNTU: SAUCE: Fix AMD GPIO based power button
Colin Ian King
colin.king at canonical.com
Fri Sep 10 07:26:26 UTC 2021
On 09/09/2021 23:28, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1943185
>
> [Impact]
>
> Power button or other wake up sources connected to GPIO
> may not wake up idle AMD systems.
>
> [Fix]
>
> Enable and disable power management wakeup mode, which is disabled by
> default, accordingly
>
> The patch series can be found @ https://lore.kernel.org/linux-gpio/20210831120613.1514899-1-Basavaraj.Natikar@amd.com/
>
> [Test]
>
> This is requested by AMD.
>
> [Where problems could occur]
>
> Only AMD systems that require GPIOs as wake sources will be affected, i.e.
> amd_gpio_irq_set_wake with "on != 0", but this is intended behaviour.
>
> Basavaraj Natikar (2):
> pinctrl: amd: Add irq field data
> pinctrl: amd: Handle wake-up interrupt
>
> drivers/pinctrl/pinctrl-amd.c | 19 ++++++++++++++-----
> drivers/pinctrl/pinctrl-amd.h | 1 +
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
Since this is directly from AMD I suspect they know how their H/W works
:-). Minor concern is the regression potential.
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the kernel-team
mailing list