NACK+Cmnt: [PATCH 0/2] [HI:linux] CONFIG_SPEAKUP=y

[Thadeu Lima de Souza Cascardo]

On Thu, Sep 09, 2021 at 09:15:01AM -0600, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1942459
> 
> SRU Justification
> 
> [Impact]
> 
> No speakup accessibility modules are available in linux-generic.
> 
> [Fix]
> 
> CONFIG_ACCESSIBILITY=y
> CONFIG_SPEAKUP=m
> 
> [Test Plan]
> 
> Unpack linux-modules-extra and check for speakup modules.
> 
> [Where problems could occur]
> 
> Enabling CONFIG_ACCESSIBILITY=y could affect console output.
> 
> [Other Info]
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Hi, Tim.

CONFIG_SPEAKUP was enabled (as a module) on 5.8 and earlier kernels. It
moved from drivers/staging/ to drivers/accessibility/ between 5.8 and 5.11,
which would explain how it ended up being disabled on 5.11 and later.

I think such explanations as the paragraph above belong to the commit
messages. Can you please add them?

Also, you are only enabling CONFIG_ACCESSIBILITY and CONFIG_SPEAKUP on
amd64-generic, whereas we had it enabled before on amd64 (both generic and
lowlatency), arm64, armhf and ppc64el. We should put it back on all of
these.

Finally, your impish commit has compiler config options changes unrelated
to this, so they should not be added to the commit in question.

Thanks.
Cascardo.