[F/H/I/Unstable][OEM-5.10/OEM-5.13/OEM-5.14][SRU][PATCH 1/1] selftests/net: remove min gso test in packet_snd

Po-Hsu Lin po-hsu.lin at canonical.com
Wed Sep 8 03:58:03 UTC 2021


From: Dust Li <dust.li at linux.alibaba.com>

BugLink: https://bugs.launchpad.net/bugs/1892213

This patch removed the 'raw gso min size - 1' test which
always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
  raw gso min size - 1 (expected to fail)
  tx: 1524
  rx: 1472
  OK

After commit 7c6d2ecbda83 ("net: be more gentle about silly
gso requests coming from user"), we relaxed the min gso_size
check in virtio_net_hdr_to_skb().
So when a packet which is smaller then the gso_size,
GSO for this packet will not be set, the packet will be
send/recv successfully.

Signed-off-by: Dust Li <dust.li at linux.alibaba.com>
Reviewed-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit cfba3fb68960b4e1fb63b4e3d95970b4a4be8577)
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
---
 tools/testing/selftests/net/psock_snd.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/testing/selftests/net/psock_snd.sh b/tools/testing/selftests/net/psock_snd.sh
index 170be65..1cbfeb5 100755
--- a/tools/testing/selftests/net/psock_snd.sh
+++ b/tools/testing/selftests/net/psock_snd.sh
@@ -86,9 +86,6 @@ echo "raw truncate hlen - 1 (expected to fail: EINVAL)"
 echo "raw gso min size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${mss_exceeds}"
 
-echo "raw gso min size - 1 (expected to fail)"
-(! ./in_netns.sh ./psock_snd -v -c -g -l "${mss}")
-
 echo "raw gso max size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${max_mss}"
 
-- 
2.7.4




More information about the kernel-team mailing list