NACK: [PATCH][HIRSUTE][FOCAL] Revert "UBUNTU: SAUCE: ext4: fix directory index node split corruption"

[Danilo Krummrich]

On Tue, Sep 07, 2021 at 09:04:02AM -0600, Tim Gardner wrote:
> 
> On 9/7/21 8:43 AM, Danilo Krummrich wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1942902
> > 
> > In order to address https://bugs.launchpad.net/bugs/1933074 the following
> > SAUCE patch was introduced.
> > 
> > Colin Ian King (1):
> >    UBUNTU: SAUCE: ext4: fix directory index node split corruption
> > 
> >   fs/ext4/namei.c | 12 +++++++-----
> >   1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > Meanwhile the issue addressed by this patch was fixed upstream with commit
> > 877ba3f729fd ("ext4: fix potential htree corruption when growing large_dir directories").
> > 
> > The upstream patch was already cherry-picked to hirsute with "upstream stable
> > patchset 2021-08-30" [1] commit ffcc845ec245) and focal with "v5.4.140 upstream
> > stable release" [2] (commit 93ad4c3f59c6).
> > 
> > [1] BugLink: https://bugs.launchpad.net/bugs/1942123
> > [2] BugLink: https://bugs.launchpad.net/bugs/1941798
> > 
> > Therefore the SAUCE patch does not serve a purpose any longer and can be
> > either dropped or reverted.
> > 
> > 
> > 
> 
> In order for the stable team to keep threads organized, it is customary to
> add a version to the subject line for re-submissions, e.g.,
> 
> [PATCH v2][HIRSUTE][FOCAL] Revert "UBUNTU: SAUCE: ext4: fix directory index
> node split corruption"
Oops, I missed that.
> 
> A short description in the cover letter should describe the differences from
> one version to the next, e.g.,
> 
> v1 -> v2: Updated BugLink to reflect new bug report number.
> 
> The subject should include the number of patches that you've sent, e.g.,
> 
> [PATCH 0/2 v2][HIRSUTE][FOCAL] ....
> 
> This helps ensure that a patch wasn't lost in transmission.
> 
> Finally, identical patch subjects are confusing. Edit the patch subject such
> that it clearly indicates the release to which it applies. For example,
> 
> [PATCH HIRSUTE] Revert "UBUNTU: SAUCE: ext4: fix directory index node split
> corruption"
> [PATCH FOCAL] Revert "UBUNTU: SAUCE: ext4: fix directory index node split
> corruption"
I had this in v1, it seems like I just messed this one up - sorry.
> 
> Patch subjects that do not have a specific release in the subject are
> assumed to apply to all releases mentioned in the cover letter subject.
> 
> rtg
> 
> 
> -----------
> Tim Gardner
> Canonical, Inc