NACK: [PATCH][HIRSUTE][FOCAL] Revert "UBUNTU: SAUCE: ext4: fix directory index node split corruption"

[Danilo Krummrich]

On 9/7/21 2:46 PM, Tim Gardner wrote:
> 
> 
> On 9/7/21 6:37 AM, Danilo Krummrich wrote:
>> On Tue, Sep 07, 2021 at 06:07:40AM -0600, Tim Gardner wrote:
>>> Since all of the bugs referenced in this report are already 'Fix 
>>> Released',
>>> I think you should create a new bug to track this specific change in 
>>> case it
>>> causes a regression.
>> I just noticed that this SAUCE patch does not serve a purpose anymore, 
>> hence
>> there is no need to carry it further and it can be removed. I don't 
>> think it
>> causes a regression though. Given this information, please let me know 
>> whether
>> creating a bug to follow up makes any sense for you.
>>
>> Danilo
> 
> The patch changes the code, it needs a new bug.I created a bug for this, therefore I will resend a new patch.

Danilo
> 
> rtg
> 
>>>
>>> rtg
>>>
>>> On 9/6/21 6:38 PM, Danilo Krummrich wrote:
>>>> In order to address https://bugs.launchpad.net/bugs/1933074 the 
>>>> following
>>>> SAUCE patch was introduced.
>>>>
>>>> Colin Ian King (1):
>>>>     UBUNTU: SAUCE: ext4: fix directory index node split corruption
>>>>
>>>>    fs/ext4/namei.c | 12 +++++++-----
>>>>    1 file changed, 7 insertions(+), 5 deletions(-)
>>>>
>>>> Meanwhile the addressed issue was fixed upstream with commit 
>>>> 877ba3f729fd
>>>> ("ext4: fix potential htree corruption when growing large_dir 
>>>> directories").
>>>>
>>>> This patch was already cherry-picked to hirsute with "upstream 
>>>> stable patchset
>>>> 2021-08-30" [1] (commit ffcc845ec245) and focal with "v5.4.140 
>>>> upstream stable
>>>> release" [2] (commit 93ad4c3f59c6).
>>>>
>>>> [1] BugLink: https://bugs.launchpad.net/bugs/1942123
>>>> [2] BugLink: https://bugs.launchpad.net/bugs/1941798
>>>>
>>>> Therefore the original SAUCE patch can be either dropped or reverted.
>>>>
>>>>
>>>>
>>>
>>> -- 
>>> -----------
>>> Tim Gardner
>>> Canonical, Inc
>