ACK/Cmnt: [SRU][I/riscv][PATCH 0/6] Unmatched enable poweroff, LEDs, mmap PCI

[Andrea Righi]

On Tue, Sep 07, 2021 at 01:39:26AM +0100, Dimitri John Ledkov wrote:
> [Impact]
> 
>  * Unable to use gpio-poweroff driver to poweroff via u-boot/opensbi/kernel
>  * Unable to use LED colors
>  * Unable to mmap PCI resources
> 
>  * Cherrypick dtb changes from meta-sifive 2021.08 release https://github.com/sifive/meta-sifive/tree/2021.08/recipes-kernel/linux/files
> 
>   * Fixup linux kernel to allow using gpio-poweroff driver for poweroff, without re-enabling back deprecated OpenSBI v0.1 extensions support (CONFIG_RISCV_SBI_V01) Submitted at https://lore.kernel.org/linux-riscv/20210907002847.111633-1-dimitri.ledkov@canonical.com/T/#u

Maybe we should add these URLs as "Link: ..." directly in the patches,
so it's easier to keep track from where they came from, simply by
looking at the git log.

Everything else looks good to me.

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> 
> [Test Plan]
> 
>  * Boot Unmatched board, poweroff, it should poweroff.
> 
>  * No test case for LEDs (will try to figure it out)
> 
>  * No test case for mmap PCI resources (needs compatible hardware)
> 
> [Where problems could occur]
> 
>  * DTB changes have already landed in opensbi/u-boot and thus kernel is being brought it line with matching support. pm_power_off reboot handling will have to change again in the future when support for OpenSBI v0.3 system reset extension is added in the kernel. When available, it will be used by default with regular power drivers probably compiled only as modules.
> 
> [Other Info]
> 
>  * Alternative to taking these patches, poweroff support could be enabled by turning back on deprecated OpenSBI v0.1 extensions, which is a step backwards. OpenSBI v0.1 will not be available in the future.
> 
> David Abdurachmanov (4):
>   riscv: sifive: unmatched: add D12 PWM LED
>   riscv: sifive: unmatched: add D2 RGB LED
>   riscv: sifive: unmatched: define LEDs color
>   riscv: sifive: unmatched: add gpio-poweroff node
> 
> Dimitri John Ledkov (1):
>   UBUNTU: SAUCE: riscv: set default pm_power_off to NULL
> 
> Stanislaw Kardach (1):
>   riscv: enable generic PCI resource mapping
> 
>  .../boot/dts/sifive/hifive-unmatched-a00.dts  | 47 +++++++++++++++++++
>  arch/riscv/include/asm/pci.h                  |  2 +
>  arch/riscv/kernel/reset.c                     | 12 +++--
>  3 files changed, 58 insertions(+), 3 deletions(-)
> 
> -- 
> 2.30.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team