ACK: [SRU][F:linux-bluefield][PATCH v1 0/2] Updates to mlx-bootctl

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

LGTM

On 10/22/21 3:46 AM, Shravan Kumar Ramani wrote:
> This submission contains 2 patches relating to the mlx-bootctl driver
> 
> 1. Check if secure boot is enabled with development keys
> BugLink: https://bugs.launchpad.net/bugs/1948434
> SRU Justification:
> 
> [Impact]
> Currently, there is no indication from mlx-bootctl when the user reads the
> lifecycle_state sysfs as to whether secure boot is enabled with development
> keys or production keys.
> In order to make this clear to the user, add a check in the driver.
> 
> [Fix]
> Check the secure boot development mode status bit. If secure boot is enabled
> with the development key, then print it to the output buffer when
> lifecycle_state_show() is invoked.
> 
> [Test Case]
> On a system in secure state, if it has been programmed with development keys,
> then reading the lifecycle_state sysfs entry in the mlx-bootctl driver should
> print a message that indicates the same.
> Similarly, a secure system which has been programmed with production keys must
> print the appropriate message when the lifecycle_state sysfs is read.
> 
> [Regression Potential]
> Can be considered minimum.
> 
> 2. Add RevID field to VPD info in EEPROM
> BugLink: https://bugs.launchpad.net/bugs/1948436
> SRU Justification:
> 
> [Impact]
> Currently, the VPD info stored in the EEPROM does not include a Rev ID. This
> field is incremented when a PN goes through minor HW changes. Sometimes, SW
> needs to differentiate the two versions of the card. Hence, this field should
> be supported in the EEPROM MFG partition.
> 
> [Fix]
> EC (Engineering Changes) field is used to denote the HW Revision of a PN. Add
> it to the EEPROM MFG and provide a sysfs entry to access the same via
> mlx-bootctl.
> 
> [Test Case]
> This field is typically programmed at the manufacturing step using the bfcfg
> tool which uses the write mechanism in the driver and then the MFG partition
> is locked. Reading the "rev" sysfs will show the current value.
> 
> [Regression Potential]
> Can be considered minimum.
> 
> Shravan Kumar Ramani (2):
>    UBUNTU: SAUCE: mlx-bootctl: Check secure boot development mode status
>      bit
>    UBUNTU: SAUCE: mlx-bootctl: Add RevID field to VPD info
> 
>   drivers/platform/mellanox/mlx-bootctl.c | 81 +++++++++++++++++++++++--
>   1 file changed, 75 insertions(+), 6 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc