[I/Unstable/OEM-5.10/OEM-5.13/OEM-5.14] [PATCH v2 3/5] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()

Kai-Heng Feng kai.heng.feng at canonical.com
Mon Oct 25 11:44:11 UTC 2021

From: Yang Yingliang <yangyingliang at huawei.com>

BugLink: https://bugs.launchpad.net/bugs/1945967

Fix the return value check which testing the wrong variable
in rtw89_cam_send_sec_key_cmd().

Reported-by: Hulk Robot <hulkci at huawei.com>
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>
Acked-by: Ping-Ke Shih <pkshih at realtek.com>
Signed-off-by: Kalle Valo <kvalo at codeaurora.org>
Link: https://lore.kernel.org/r/20211018033102.1813058-1-yangyingliang@huawei.com
(cherry picked from commit a04310edcd00d6014126483a2d8cd95b4786db25 linux-next)
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
 drivers/net/wireless/realtek/rtw89/cam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/cam.c b/drivers/net/wireless/realtek/rtw89/cam.c
index c1e8c76c6acaf..ad7a8155dbed3 100644
--- a/drivers/net/wireless/realtek/rtw89/cam.c
+++ b/drivers/net/wireless/realtek/rtw89/cam.c
@@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev,
 		return 0;
 	ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true);
-	if (!skb) {
+	if (!ext_skb) {
 		rtw89_err(rtwdev, "failed to get ext sec key command\n");
 		return -ENOMEM;

More information about the kernel-team mailing list