ACK: [SRU][B][PATCH 0/2] Drop "UBUNTU: SAUCE: cachefiles: Page leaking in cachefiles_read_backing_file while vmscan is active"

[Kamal Mostafa]

LGTM.

Acked-by: Kamal Mostafa <kamal at canonical.com>

 -Kamal

On Tue, Oct 19, 2021 at 05:27:26PM +0200, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1947709
> 
> [Impact]
> 
> "UBUNTU: SAUCE: cachefiles: Page leaking in cachefiles_read_backing_file while
> vmscan is active" has been applied to fix a page leaking issue.
> 
> However a slightly different fix has been applied upstream to address
> the same issue:
> 
>  9a24ce5b66f9 ("cachefiles: Fix page leak in cachefiles_read_backing_file while vmscan is active")
> 
> We should drop the SAUCE patch and rely on the upstream fix.
> 
> [Test case]
> 
> No test case or reproducer is available at the moment, this issue has been
> found simply by reviewing the code.
> 
> [Fix]
> 
> Drop the SAUCE patch and rely on the upstream fix.
> 
> [Regression potential]
> 
> If the analysis is not correct we may re-introduce a page leak in cachefiles
> (NFS for example), but it seems unlikely to happen, since the upstream fix is
> addressing the page leaking already.
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team