ACK: [SRU Bionic/Focal/Hirsute/Impish 0/2] LP: #1947161 - ACL updates on OCFS2 are not revalidated

Tim Gardner tim.gardner at canonical.com
Thu Oct 14 15:51:24 UTC 2021


Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 10/14/21 7:51 AM, Thadeu Lima de Souza Cascardo wrote:
> https://bugs.launchpad.net/bugs/1947161
> 
> [Impact]
> When ACLs are updated on OCFS2, their caches are not revalidated, requiring remounts to be able to see the updates.
> 
> [Fix]
> Upstream commits:
> 504ec37dfdfbf9c65166c51f7b12126d2a9b18dc ("ocfs2: fix remounting needed after setfacl command")
> 9c0f0a03e386f4e1df33db676401547e1b7800c6 ("ocfs2: drop acl cache for directories too")
> 
> [Test case]
> On a single node:
> setfacl -m u:user1:rwX dir1
> getfacl dir1
> 
> On multiple nodes:
> Node1:
> getfacl dir1
> 
> Node2:
> getfacl dir1
> 
> Node1:
> setfacl -m u:user1:rwX dir1
> getfacl dir1
> 
> Node2:
> getfacl dir1
> 
> [Potential regression]
> ACL changes on OCFS2 may stop working properly.
> 
> Gang He (1):
>    ocfs2: fix remounting needed after setfacl command
> 
> Wengang Wang (1):
>    ocfs2: drop acl cache for directories too
> 
>   fs/ocfs2/acl.c     | 2 ++
>   fs/ocfs2/dlmglue.c | 3 ++-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list