NAK[I]: [PATCH 0/3][SRU][[I][OEM-5.13][OEM-5.14][Unstable] Can only

Kleber Souza kleber.souza at canonical.com
Thu Oct 14 13:51:48 UTC 2021


On 11.10.21 06:16, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1946433
> 
> [Impact]
> System only can reach PC3, and it affects power consumption alot.
> 
> [Fix]
> Kaiheng implemented a dynamic ASPM for r8169, it not only fixes the PC
> state issue, but also fixes network speed issue.
> https://patchwork.ozlabs.org/project/linux-pci/cover/20211007161552.272771-1-kai.heng.feng@canonical.com/
> 
> [Test]
> Verified on 2 different systems which has PC state issue and has network
> speed issue, these patches fix both issues.
> 
> [Where problems could occur]
> It toggles ASPM on and off depends on the network traffic during runtime,
> I don't think it'll lead to any regressions. Some potential issues have
> been addressed during the patch submitting. It's v6 now and accepted by
> upstream.
> 
> Kai-Heng Feng (3):
>    PCI/ASPM: Introduce a new helper to report ASPM capability
>    r8169: Enable chip-specific ASPM regardless of PCIe ASPM status
>    r8169: Implement dynamic ASPM mechanism
> 
>   drivers/net/ethernet/realtek/r8169_main.c | 69 ++++++++++++++++++++---
>   drivers/pci/pcie/aspm.c                   | 11 ++++
>   include/linux/pci.h                       |  2 +
>   3 files changed, 73 insertions(+), 9 deletions(-)
> 

These patches are not yet applied to Linus' nor linux-next tree, so
they are not stable material yet (for Impish).

 From the patchwork discussion I can see that this patch series has
received some comments and there are some indication that Kai-Heng
will send another revision for at least some of these patches.

Can you please submit these patches again for Impish when they are
applied at least to linux-next?

Thanks,
Kleber



More information about the kernel-team mailing list