ACK: [SRU][Focal][PATCH 0/1] fix rtnetlink.sh for older iproute2 (LP#1896448)

Tim Gardner tim.gardner at canonical.com
Fri Oct 8 15:08:14 UTC 2021


Acked-by: Tim Gardner <tim.gardner at canonical.com>

Anything to cut down on false negative test results.

On 10/8/21 8:39 AM, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1896448
> 
> [ Impact ]
> When running the net/rtnetlink.sh selftest from v5.4 on older Ubuntu releases
> (e.g. Bionic 18.04), some of the iproute2 CLI options are not available causing
> the testcase to fail.
> 
> [ Fix ]
> SAUCE patch to detect whether some options not present on older iproute2
> versions are available, skipping or adapting the tests.
> 
> [ Test ]
> Run net/rtnetlink.sh on 5.4 kernels with both Focal and Bionic userspace. The
> test should complete without introducing regressions on Focal and without
> breaking on Bionic.
> 
> [ Where problems could occur ]
> If the checks for the available interfaces are not done correctly, we could end
> up having a smaller coverage on Focal or the tests would still break in Bionic.
> 
> Kleber Sacilotto de Souza (1):
>    UBUNTU: SAUCE: selftests: rtnetlink: fixes for older iproute2
> 
>   tools/testing/selftests/net/rtnetlink.sh | 153 +++++++++++++++--------
>   1 file changed, 100 insertions(+), 53 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list