ACK/cmnt: [SRU][Impish][PATCH 0/2] Remove the downstream xr-usb-uart driver

[Kleber Souza]

On 04.10.21 07:57, Shrirang Bagul wrote:
> BugLink: https://bugs.launchpad.net/bugs/1945938
> 
> [Impact]
> The xr-usb-serial custom (downstream vendor) driver was added in Xenial LTS kernel
> to add support for USB UART chips:
> Family: USB UART
> Part Numbers:
>      XR21V1410, XR21V1412, XR21V1414,
>      XR21B1411, XR21B1420, XR21B1422,
>      XR21B1424, XR22801, XR22802,
>      XR22804
> 
> [Fix]
> In 5.13.x, support for these devices was added to the kernel via. following patch series:
> Link: https://lore.kernel.org/all/20210412095557.1213-1-johan@kernel.org/
> 
> There have been long term maintenance challenges with the downstream vendor driver
> over the period of time (since 4.4.y based Xenial LTS). Now that upstream driver
> supports most of the above part numbers, let's remove this redundant out-of-tree driver.
> 
> [Test]
> The driver was functionally verified to work fine with XR21V1412. The support for
> other chips with part numbers mentioned above are also supported with the above
> patch series.
> 
> [Where problems could occour]
> The downstream driver was designed to work with specific BIOS configs only
> defined on an IoT GW project which is locked to use only Xenial ESM and Bionic LTS
> kernels, there is a low chance of regression on the Impish series.
> 
> Shrirang Bagul (2):
>    UBUTNU: SAUCE: xr-usb-serial: remove driver
>    UBUNTU: [Config] update modules list
> 
>   debian.master/abi/amd64/generic.modules     |    1 -
>   debian.master/abi/amd64/lowlatency.modules  |    1 -
>   ubuntu/Makefile                             |    6 -
>   ubuntu/xr-usb-serial/Makefile               |   15 -
>   ubuntu/xr-usb-serial/README.txt             |   50 -
>   ubuntu/xr-usb-serial/xr_usb_serial_common.c | 1796 -------------------
>   ubuntu/xr-usb-serial/xr_usb_serial_common.h |  187 --
>   ubuntu/xr-usb-serial/xr_usb_serial_hal.c    |  724 --------
>   ubuntu/xr-usb-serial/xr_usb_serial_ioctl.h  |   31 -
>   9 files changed, 2811 deletions(-)
>   delete mode 100644 ubuntu/xr-usb-serial/Makefile
>   delete mode 100644 ubuntu/xr-usb-serial/README.txt
>   delete mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_common.c
>   delete mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_common.h
>   delete mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_hal.c
>   delete mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_ioctl.h
> 

Thanks for this patch!

Apart from the minor comment on the subject line on Patch 1/2
it looks good:


Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

Thanks