ACK/Cmnt: [SRU] [I/Unstable/OEM-5.13/OEM-5.14] [PATCH 0/3] Fix non-working e1000e device after resume

Stefan Bader stefan.bader at canonical.com
Wed Nov 24 13:37:51 UTC 2021


On 22.11.21 17:37, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1951861
> 
> [Impact]
> e1000e devices stop working after s2idle resume.
> 
> [Fix]
> Revert the offending patch series, which is to bring some minor power
> saving.
> 
> [Test]
> Vendor did extensive tests and didn't find any regression, and the power
> consumption remains the same.
> 
> [Where problems could occur]
> Maybe on some system the series can save some energy, so reverting will
> cause some power consumption increase.
> 
> Kai-Heng Feng (3):
>    Revert "e1000e: Additional PHY power saving in S0ix"
>    Revert "e1000e: Add polling mechanism to indicate CSME DPG exit"
>    Revert "e1000e: Add handshake with the CSME to support S0ix"
> 
>   drivers/net/ethernet/intel/e1000e/ich8lan.h |   3 -
>   drivers/net/ethernet/intel/e1000e/netdev.c  | 358 +++++++++-----------
>   drivers/net/ethernet/intel/e1000e/regs.h    |   1 -
>   3 files changed, 154 insertions(+), 208 deletions(-)
> 
Looking at Impish, those patches have been applied there without marking them as 
SAUCE despite them being from net-next (even linux-next is no guarantee that 
something reaching the main tree but at least has some higher chance). What I 
try to say is that we probably want to be a little more careful on where things 
come from even for devel.

For reverting:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20211124/6c71e294/attachment-0001.sig>


More information about the kernel-team mailing list