ACK: [F][PATCH 0/1] rtc: class: support hctosys from modular RTC drivers

Tim Gardner tim.gardner at canonical.com
Wed Nov 24 13:14:49 UTC 2021


Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 11/24/21 4:01 AM, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1952077
> 
> == Impact ==
> Although we have CONFIG_RTC_HCTOSYS enabled and set CONFIG_RTC_HCTOSYS_DEVICE
> to "rtc0", system time would only be set if the RTC driver is built-in. This
> may not be an issue on most amd64 systems because CONFIG_RTC_DRV_CMOS is y
> for amd64, however it is an issue for other architectures since there may not
> be a proper RTC driver enabled as built-in. Also making every RTC driver that
> may be used as built-in is not a good option.
> 
> == Fix ==
> The commit is in mainline since v5.7:
> 
> == Risk of Regression ==
> It's a clean cherry-pick for v5.4 and looks straight forward so risk should be low.
> 
> 
> Steve Muckle (1):
>    rtc: class: support hctosys from modular RTC drivers
> 
>   drivers/rtc/Kconfig   |  3 --
>   drivers/rtc/Makefile  |  1 -
>   drivers/rtc/class.c   | 61 ++++++++++++++++++++++++++++++++++++++
>   drivers/rtc/hctosys.c | 69 -------------------------------------------
>   4 files changed, 61 insertions(+), 73 deletions(-)
>   delete mode 100644 drivers/rtc/hctosys.c
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list