NACK/Cmnt: [SRU][F][PATCH 0/1] Fix storage size of ‘md’ isn’t known issue in selftests/seccomp for B/5.4

[Stefan Bader]

On 26.10.21 19:19, Luke Nowakowski-Krijger wrote:
> BugLink: https://bugs.launchpad.net/bugs/1896420
> 
> [Impact]
> 
> Test fails to build in selftests/seccomp/seccomp_bpf.c with
> 'error: storage size of ‘md’ isn’t known' due to the type
> struct seccomp_metadata not being defined for B/5.4 kernels.
> 
> [Test case]
> 
> Test successfully builds and test cases pass both on Bionic/5.4 and on Focal
> 
> [Fixes]
> 
> Unconditionally define struct seccomp_metadata.
> Remove linux/ptrace.h where a definition of seccomp_metadata is already being
> defined in Focal.
> 
> [Potential regression]
> 
> There could be future build failures if glibc headers get updated to
> include definitions of struct seccomp_metadata or if linux/ptrace.h gets updated
> to include needed definitions.
> 
> Luke Nowakowski-Krijger (1):
>    UBUNTU: SAUCE: selftests/seccomp: fix 'storage size of ‘md’ isn’t
>      known' build issue
> 
>   tools/testing/selftests/seccomp/seccomp_bpf.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
My reading of the discussion is that there will be a v2 submission which adds 
some more explanation in the code why things are needed/done this way. To 
clarify this I am rejecting this thread.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20211109/9b0a466c/attachment.sig>