ACK: [PATCH][focal/linux, focal/linux-aws] UBUNTU: SAUCE: aws: Fix backport of RDMA/efa: Expose maximum TX doorbell batch

Thadeu Lima de Souza Cascardo cascardo at canonical.com
Fri Nov 5 13:06:02 UTC 2021


On Thu, Nov 04, 2021 at 12:38:01PM -0600, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1949882
> 
> The backport of ("RDMA/efa: Expose maximum TX doorbell batch") was incorrect in
> that it missed the addition of a structure variable. Though unused by
> the driver, it is a shared structure between the device and the driver,
> and must therefore have the correct offsets.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
> 

Restricted to this one driver, vendor confirmed that it works.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>

> This patch is particularly important for AWS as they are currently testing RDMA functionality.
> I would like to get this appplied to at least focal/linux-aws for the 2021.11.08 SRU cycle.
> 
> This patch has been confirmed to fix the issue that AWS was having.
> 
> rtg
> ---
>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> index bfa98ef9a4853..0507880b1f457 100644
> --- a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> +++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> @@ -610,6 +610,9 @@ struct efa_admin_feature_queue_attr_desc {
>  	/* The maximum size of LLQ in bytes */
>  	u32 max_llq_size;
>  
> +	/* Maximum number of SGEs for a single RDMA read WQE */
> +	u16 max_wr_rdma_sges;
> +
>  	/*
>  	 * Maximum number of bytes that can be written to SQ between two
>  	 * consecutive doorbells (in units of 64B). Driver must ensure that only
> -- 
> 2.33.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list