ACK/Cmnt: [SRU] [Focal] [PULL] [PATCH v2 0/4] qla2xxx: bug fixes

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Mon May 31 10:20:23 UTC 2021


On 28/05/2021 12:42, Nilesh Javali wrote:
> BugLink: https://bugs.launchpad.net/bugs/1860724
> 
> SRU Justification:
> 
> [Impact]
> 
> * On Ubuntu 20.04, NVMe Target will not get discovered in N2N
> * configuration. The discovery was failing because Initiator was
> * trying FC PRLI instead of NVMe PRLI.
> 
> [Fix]
> 
> * The driver code changes to handle NVMe N2N configuration and send PRLI
> * based on the target.
> 
> [Test Plan]
> 
> * Load driver in NVMe N2N configuration and NVMe devices should be
> * discovered by an Initiator.
> 
> [Where problems could occur]
> 
> * NVMe N2N configuration.
> 
> [Other Info]
> 
> * The bug is with inbox qla2xxx driver and needs update.
> * All the qla2xxx driver bug fixes are part of upstream kernel.
> * The repo used is,
> * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal
> * The base-commit used to apply these bug fixes is at the bottom.
> 
> Arun Easi (1):
>   scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue
> 
> Quinn Tran (1):
>   scsi: qla2xxx: Serialize fc_port alloc in N2N
> 
> Quinn Trann (2):
>   scsi: qla2xxx: Set Nport ID for N2N
>   scsi: qla2xxx: Fix N2N and NVMe connect retry failure
> 
>  drivers/scsi/qla2xxx/qla_def.h  |  2 +
>  drivers/scsi/qla2xxx/qla_init.c | 68 ++++++++++++++++++++++++++-------
>  drivers/scsi/qla2xxx/qla_mbx.c  | 47 ++++++++++++-----------
>  drivers/scsi/qla2xxx/qla_os.c   | 10 +++--
>  4 files changed, 88 insertions(+), 39 deletions(-)
> 


Thanks for the patches, they look good except one minor thing - these
are all commits from mainline kernel, so backport line should look like:

(backported from commit 11efe8755d73efd153d6459240866b6d52448f19)

This could be fixed when applying.

Additionally this is not a pull request but regular backport submission,
so no need for PULL in the subject.

Best regards,
Krzysztof



More information about the kernel-team mailing list