ACK/Cmnt: [PATCH 0/6][SRU][G][H][Unstable] Add support for IO functions of AAEON devices

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

All of the changes to Kconfig and Makefile look reasonable. Chance of 
regression is low since each driver only completes loading if its on the 
right platform, e.g.,

+	if (!wmi_has_guid(AAEON_WMI_MGMT_GUID)) {
+		dev_info(&wdev->dev, "AAEON Management GUID not found\n");
+		return -ENODEV;
+	}

Fix the 'Review-by:' misspelling at apply time.

rtg

On 5/25/21 4:17 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for AAEON
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  11 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  11 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  11 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  12 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1313 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
> 

-- 
-----------
Tim Gardner
Canonical, Inc