NAK: [SRU][F][PATCH v3 1/1] Add support for device id 0x159b.

[Kleber Souza]

On 26.05.21 23:05, Michael Reed wrote:
> From: Bruce Allan <bruce.w.allan at intel.com>
> 
> BugLink:  https://bugs.launchpad.net/bugs/1912511
> 
> Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> (backported from commit 195fb97766da1b41b4d49bccc37e13603bcb49cc)
> Signed-off-by: Michael Reed <michael.reed at canonical.com>

This patch is not keeping the original commit subject and comments:

$ git show 195fb97766da1b41b4d49bccc37e13603bcb49cc
commit 195fb97766da1b41b4d49bccc37e13603bcb49cc
Author: Bruce Allan <bruce.w.allan at intel.com>
Date:   Thu Feb 13 13:31:27 2020 -0800

     ice: add additional E810 device id
     
     Add support for device id 0x159b.
     
     Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
     Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
     Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
     Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>


"Add support for device id 0x159b." should be in the email body and
"ice: add additional E810 device id" as its subject.

This is done automatically by git when creating the patch with something
like:

$ git format-patch -1 <sha1>

Then you only need to add the "(backported from ...)" and your
Signed-off-by lines at the bottom if the commit doesn't have them yet.


Could you please resend?


Thanks,
Kleber


> ---
>   drivers/net/ethernet/intel/ice/ice_devids.h | 2 ++
>   drivers/net/ethernet/intel/ice/ice_main.c   | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index f8d5c661d0ba..862a5caa760f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -11,5 +11,7 @@
>   #define ICE_DEV_ID_E810C_QSFP		0x1592
>   /* Intel(R) Ethernet Controller E810-C for SFP */
>   #define ICE_DEV_ID_E810C_SFP		0x1593
> +/* Intel(R) Ethernet Controller E810-XXV for SFP */
> +#define ICE_DEV_ID_E810_XXV_SFP		0x159B
>   
>   #endif /* _ICE_DEVIDS_H_ */
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index d0ccb7ad447b..bfab9bc34d4b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -3179,6 +3179,7 @@ static const struct pci_device_id ice_pci_tbl[] = {
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_BACKPLANE), 0 },
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_QSFP), 0 },
>   	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_SFP), 0 },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_SFP), 0 },
>   	/* required last entry */
>   	{ 0, }
>   };
>