NACK: [SRU][F][PATCH 1/1] Add support for device id 0x159b. This device id provides support for the E810 NIC

[Juerg Haefliger]

Please don't change the subject and content of the original upstream commit.

Also, this seems to be the 2nd iteration so for your next submission,
please use [PATCH v3], so we know it supersedes previous patches.


> From: Michael Reed <Michael.Reed at canonical.com>

Hmm. That should read 'From: Bruce Allan <bruce.w.allan at intel.com>'
since he is the original author of the upstream commit but this indicates
that you authored the commit. Did you really cherry pick the commit like 'git
cherry-pick -x -s 195fb97766da1b4?


> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912511

Short form please:  https://bugs.launchpad.net/bugs/1912511


> Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> (backported from commit 195fb97766da1b41b4d49bccc37e13603bcb49cc)

For backports, we like a short description what needed to be changed,
enclosed in square brackets. See for example:
https://lists.ubuntu.com/archives/kernel-team/2021-May/120660.html


> Signed-off-by: Michael Reed <michael.reed at canonical.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_devids.h | 3 ++-
>  drivers/net/ethernet/intel/ice/ice_main.c   | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index f8d5c661d0ba..09d91ae34093 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -11,5 +11,6 @@
>  #define ICE_DEV_ID_E810C_QSFP		0x1592
>  /* Intel(R) Ethernet Controller E810-C for SFP */
>  #define ICE_DEV_ID_E810C_SFP		0x1593
> -

Dropping that newline is not part of the original patch.

...Juerg


> +/* Intel(R) Ethernet Controller E810-XXV for SFP */
> +#define ICE_DEV_ID_E810_XXV_SFP		0x159B
>  #endif /* _ICE_DEVIDS_H_ */
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index d0ccb7ad447b..bfab9bc34d4b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -3179,6 +3179,7 @@ static const struct pci_device_id ice_pci_tbl[] = {
>  	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_BACKPLANE), 0 },
>  	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_QSFP), 0 },
>  	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810C_SFP), 0 },
> +	{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E810_XXV_SFP), 0 },
>  	/* required last entry */
>  	{ 0, }
>  };

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210526/a779ceac/attachment.sig>