ACK: [F/F-OEM-5.6][SRU][PATCH 0/1] Mark kprobe_args_user.tc in kselftest/ftrace as unsupported

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 5/25/21 3:42 AM, Po-Hsu Lin wrote:
> [Impact]
> This kprobe_args_user.tc test will be marked as "unresolved" and once
> causing failures in ftrace of our ubuntu_kernel_selftests (lp:1869227)
> 
> Our workaround is to blacklist this test in autotest-client-tests [1]
> 
> Note that with b730d668138cb3 ("ftrace/selftest: make unresolved cases
> cause failure if --fail-unresolved set") available, an unresolved case
> will not be treated as a failure unless we requested so.
> 
> [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/commit/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py?id=a381d47a9004388730e825cd20566ef102a29399
> 
> [Fix]
> * 1e11b7dbef17bb selftests/ftrace: Return unsupported for the
> unconfigured features
> 
> With this patch it will be marked as unsupported, easier to understand
> than unresolved.
> 
> This patch can be found in Groovy and newer releases, and this test
> does not exist in Bionic and older releases. It's rather trivial to
> fix this in F-OEM-5.6 as we don't run s390x / PowerPC with it.
> 
> [Test]
> Tested on s390x / PowerPC, this will be marked as unsupported:
> $ sudo ./ftracetest test.d/kprobe/kprobe_args_user.tc
> === Ftrace unit tests ===
> [1] Kprobe event user-memory access	[UNSUPPORTED]
> 
> # of passed:  0
> # of failed:  0
> # of unresolved:  0
> # of untested:  0
> # of unsupported:  1
> # of xfailed:  0
> # of undefined(test bug):  0
> $ echo $?
> 0
> 
> [Where problems could occur]
> Changes limited to testing tool, should not impact real kernel
> functionality. With this patch and local workaround in
> autotest-client-tests removed we might see this failing for
> s390x / PowerPC in the future.
> 
> Masami Hiramatsu (1):
>    selftests/ftrace: Return unsupported for the unconfigured features
> 
>   tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc