ACK: [SRU][F:linux-bluefield][PATCH v1 1/1] UBUNTU: SAUCE: mlxbf_gige: syncup with v1.23 content

[Krzysztof Kozlowski]

On 21/05/2021 14:45, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928852
> 
> This delivery provides a syncup of the mlxbf_gige driver
> with the Mellanox-internal v1.23 content.
> 
> A) v1.22 changes
> ----------------
> This delivery provides a set of changes to add stability to
> the mlxbf_gige driver transmit and receive processing:
> 
> Changes to mlxbf_gige_rx_packet()
> ---------------------------------
> 1) Changed logic to remove the assumption that there's at
>    least one packet to process. Instead, at the start of
>    routine check the RX CQE polarity bit, and if it is not
>    the expected value then exit.
> 
> 2) Moved call to "dma_unmap_single()" to within the path
>    where packet status is OK.  Otherwise if an errored
>    packet is received, the SKB is unmapped but no SKB is
>    allocated to fill that same index.
> 
> 3) Defer call to "netif_receive_skb()" to end of routine
>    since this call can trigger more processing, even
>    packet transmissions, in the networking stack.
> 
> Changes to mlxbf_gige_start_xmit()
> ----------------------------------
> 1) Added logic to drop oversized packets
> 
> 2) Added logic to use a spin lock when access priv->tx_pi
>    since this index is also accessed by the transmit
>    completion logic.
> 
> Changes to mlxbf_gige_handle_tx_complete
> ----------------------------------------
> 1) Added call to "mb()" to flush prev_tx_ci updates
> 
> B) v1.23 changes
> ----------------
> This delivery improves the error handling in the driver's
> open() method so that IRQs and receive resources are freed,
> as appropriate, if an error is encountered.
> 
> Reviewed-by: Asmaa Mnebhi <asmaa at nvidia.com>
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> ---
>  .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |  2 +
>  .../mellanox/mlxbf_gige/mlxbf_gige_main.c     | 27 +++++++----
>  .../mellanox/mlxbf_gige/mlxbf_gige_rx.c       | 45 +++++++++++++------
>  .../mellanox/mlxbf_gige/mlxbf_gige_tx.c       | 20 +++++----
>  4 files changed, 64 insertions(+), 30 deletions(-)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>


Best regards,
Krzysztof