NAK: [SRU][H][PATCH 2/5] x86/kvm: Teardown PV features on boot CPU as well

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Thu May 20 17:32:29 UTC 2021


On 20/05/2021 09:41, Andrea Righi wrote:
> From: Vitaly Kuznetsov <vkuznets at redhat.com>
> 
> Various PV features (Async PF, PV EOI, steal time) work through memory
> shared with hypervisor and when we restore from hibernation we must
> properly teardown all these features to make sure hypervisor doesn't
> write to stale locations after we jump to the previously hibernated kernel
> (which can try to place anything there). For secondary CPUs the job is
> already done by kvm_cpu_down_prepare(), register syscore ops to do
> the same for boot CPU.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets at redhat.com>
> Message-Id: <20210414123544.1060604-3-vkuznets at redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> (backported from commit 8b79feffeca28c5459458fe78676b081e87c93a4)
> Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
> ---
>  arch/x86/kernel/kvm.c | 57 +++++++++++++++++++++++++++++++------------
>  1 file changed, 41 insertions(+), 16 deletions(-)
> 

For the same reasons as focal - backport is quite different and the
kvm_guest_cpu_offline() location looks now wrong. This might not build
on !SMP, similarly as on Focal.


Best regards,
Krzysztof



More information about the kernel-team mailing list