ACK: [SRU][F:linux-bluefield][PATCH v2 0/2] Remove dependency between module and driver

Kleber Souza kleber.souza at canonical.com
Thu May 20 08:20:47 UTC 2021


On 20.05.21 00:02, Daniel Jurgens wrote:
> This series should be applied after the backport of bc8e71314e84, which is already sent.
> 
> SRU Justification:
> 
> The patches are for removing module dependency between software module and driver module.
> 
> * Explain the bug(s)
> 
> Without the patches there is a dependency between mlx5_core, act_ct and nf_flow_table.
> 
> * brief explanation of fixes
> 
> The fix is moving used function from c source file to header file.
> 
> * How to test
> 
> Check module dependency with modinfo, lsmod, etc.
> 
> * What it could break.
> 
> If a sofwtare module doesn't exists, i.e. disabling in .config. then the driver module, mlx5_core,
> in this case will fail to load.
> 
> v2: Apply after "netfilter: flowtable: Free block_cb when being deleted" to avoid
>      merge conflict for the maintainers.
> 
> Alaa Hleihel (2):
>    net/sched: act_ct: Make tcf_ct_flow_table_restore_skb inline
>    netfilter: flowtable: Make nf_flow_table_offload_add/del_cb inline
> 
>   include/net/netfilter/nf_flow_table.h | 49 ++++++++++++++++++++++++++++++++---
>   include/net/tc_act/tc_ct.h            | 11 +++++++-
>   net/netfilter/nf_flow_table_core.c    | 46 --------------------------------
>   net/sched/act_ct.c                    | 11 --------
>   4 files changed, 55 insertions(+), 62 deletions(-)
> 

Thanks Daniel for refreshing the patches.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>





More information about the kernel-team mailing list