ACK: [PATCH 0/12][FG/linux-azure] Add MANA network driver

[Guilherme Piccoli]

On Tue, May 18, 2021 at 12:08 PM Tim Gardner <tim.gardner at canonical.com> wrote:
> [...]
> > Thanks for the patch Tim! I'm almost ACKing, I just have 2 questions/comments:
> >
> > (a) I've noticed you sent basically a full series for Focal and a full
> > series for Groovy - all patches seems to have different offsets (at
> > least) in both series.
> > That said, in some patches you marked both F and G was "cherry picked
> > from SHA1" - shouldn't it be "backported from SHA1" for at least one
> > of the series, since you seem to have changed the offsets to apply the
> > patch?
> >
>
> 'git cherry-pick' has better default context (or offset) handling then
> 'git am', which is how these patches will be applied. Plus, I find it
> easier to select and save patches as a block for a specific series
> rather then have to tease the correct patches from an integrated list of
> patches.
>
> > (b) About patch 6, I understand that for Focal patch, you added an
> > extra hunk removing some stuff there. The change itself makes sense to
> > me, but I'd suggest an extra SAUCE patch for that, it's not directly
> > related to patch 6 right?
> >
>
> It is related in that it was part of the backport. The commit
> cherry-picked cleanly, but netdev_lockdep_set_classes() did not exist in
> v5.4 which caused an FTBS (which is why the fix has to be part of this
> patch). I fenced it using '#if LINUX_VERSION_CODE' specifically so that
> it would attract reviewer attention. I wanted some assurance that
> removing the call to netdev_lockdep_set_classes() did not appear to have
> any material impact.
>
> rtg


Very good then, thanks for the clarification!
Acked-by: Guilherme G. Piccoli <gpiccoli at canonical.com>