ACK: [PATCH][bionic:linux-raspi2] UBUNTU: [Config] raspi2: CONFIG_LATENCYTOP=n

[Kamal Mostafa]

LGTM.

Acked-by: Kamal Mostafa <kamal at canonical.com>

 -Kamal

On Thu, May 13, 2021 at 03:10:58PM -0700, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928394
> 
> There were some recent changes on the main kernels to fix some syntax issues with the annotations files (Propagate "Update annotations and fix errors" to all derivatives), after I replicated the changes from bionic/linux to bionic/linux-raspi2 I started getting this enforcement error:
> 
> check-config: FAIL (y != n): CONFIG_LATENCYTOP policy<{'amd64-generic': 'n', 'amd64-lowlatency': 'y', 'arm64': 'n', 'armhf': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}> mark<ENFORCED> note<https://lists.ubuntu.com/archives/kernel-team/2014-July/045006.html, LP#1655986>
> It seems we were supposed to have the same enforcement as the main kernel (= n) but the raspi2 config has it actually enabled.
> 
> Looking at the url and the bug reference on the enforcement notes, it seems
> it doesn't make much sense to keep it enabled for non-lowlatency kernels.
> 
> @juerghaefliger confirmed we should disable this option:
> 
> Yes, it should be disabled. I did the same for hirsute earlier this year after
> Seth fixed the master config annotations:
> ~ubuntu-kernel/ubuntu/+source/linux-raspi/+git/hirsute - [no description]
> 
> If I remember correctly I made some other config changes due to Seth's
> changes.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  debian.raspi2/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.raspi2/config/config.common.ubuntu b/debian.raspi2/config/config.common.ubuntu
> index e024862197840..51b19efdfba9c 100644
> --- a/debian.raspi2/config/config.common.ubuntu
> +++ b/debian.raspi2/config/config.common.ubuntu
> @@ -3032,7 +3032,7 @@ CONFIG_L2TP_IP=m
>  CONFIG_L2TP_V3=y
>  CONFIG_LAPB=m
>  CONFIG_LAPBETHER=m
> -CONFIG_LATENCYTOP=y
> +# CONFIG_LATENCYTOP is not set
>  CONFIG_LATTICE_ECP3_CONFIG=m
>  CONFIG_LBDAF=y
>  CONFIG_LCD_AMS369FG06=m
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team