NAK: [SRU][F:linux-bluefield][PATCH 1/2] net/sched: act_ct: Make tcf_ct_flow_table_restore_skb inline

Daniel Jurgens danielj at nvidia.com
Tue May 11 18:01:46 UTC 2021


> From: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Sent: Tuesday, May 11, 2021 1:00 PM 
> On 11/05/2021 13:50, Daniel Jurgens wrote:
> > From: Alaa Hleihel <alaa at mellanox.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/1927246
> >
> > Currently, tcf_ct_flow_table_restore_skb is exported by act_ct module,
> > therefore modules using it will have hard-dependency on act_ct and
> > will require loading it all the time.
> >
> > This can lead to an unnecessary overhead on systems that do not use
> > hardware connection tracking action (ct_metadata action) in the first
> > place.
> >
> > To relax the hard-dependency between the modules, we unexport this
> > function and make it a static inline one.
> >
> > Fixes: 30b0cf90c6dd ("net/sched: act_ct: Support restoring conntrack
> > info on skbs")
> > Signed-off-by: Alaa Hleihel <alaa at mellanox.com>
> > Reviewed-by: Roi Dayan <roid at mellanox.com>
> > Acked-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> > Signed-off-by: David S. Miller <davem at davemloft.net> (cherry picked
> > from commit 762f926d6f19b9ab4dee0f98d55fc67e276cd094)
> 
> Thanks for the patch.
> 
> Your SoB here is missing.
> 

Sorry. Will resubmit.

> 
> Best regards,
> Krzysztof


More information about the kernel-team mailing list