ACK/Cmnt: [SRU][H/raspi][PATCH] UBUNTU: [Config] raspi: Set BCM_VCIO=y

[Juerg Haefliger]

On Mon, 10 May 2021 06:15:56 -0600
Tim Gardner <tim.gardner at canonical.com> wrote:

> Acked-by: Tim Gardner <tim.gardner at canonical.com>
> 
> Don't you also have to drop vcio from the ABI files lest you get the 
> always amusing build failure message "EE: Missing modules (start begging 
> for mercy)".

Yes. But if I include that change in this patch then it is dropped during
cranky open. Which reminds me that I should work on a cranky open fix for
that... And we should fix the ABI check to not complain about 'm' -> 'y'
changes (which is also on my todo list somewhere).

...Juerg


> rtg
> 
> On 5/10/21 2:06 AM, Juerg Haefliger wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1927505
> > 
> > This driver was accidentally turned into a module during a raspberrypi
> > update. Change it back to built-in since the driver isn't loaded
> > automatically.
> > 
> > Signed-off-by: Juerg Haefliger <juergh at canonical.com>
> > ---
> >   debian.raspi/config/config.common.ubuntu | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
> > index 27b26cac1f35..5a771a6dc437 100644
> > --- a/debian.raspi/config/config.common.ubuntu
> > +++ b/debian.raspi/config/config.common.ubuntu
> > @@ -766,7 +766,7 @@ CONFIG_BCMGENET=y
> >   CONFIG_BCM_KONA_USB2_PHY=m
> >   CONFIG_BCM_NET_PHYLIB=y
> >   CONFIG_BCM_SBA_RAID=m
> > -CONFIG_BCM_VCIO=m
> > +CONFIG_BCM_VCIO=y
> >   CONFIG_BCM_VC_SM_CMA=m
> >   CONFIG_BCM_VIDEOCORE=y
> >   CONFIG_BD70528_WATCHDOG=m
> >   
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210510/eefb24c8/attachment.sig>