APPLIED: [SRU][F:bluefield][PATCH v0 1/1] UBUNTU: SAUCE: mlx-trio: Use rate-limited prints in interrupt handler

[Tim Gardner]

Applied to focal:bluefield/master-next. Thanks.

-rtg

On 4/28/21 5:15 AM, Shravan Kumar Ramani wrote:
> BugLink: https://bugs.launchpad.net/bugs/1926424
> 
> The mlx-trio module's IRQ handler prints errors and additional debug info in case of errors.
> However, these prints can be excessive in certain cases, thereby interfering with other functions.
> This patch limits the message amount.
> 
> SRU Justification:
> 
> [Impact]
> In cases where the mlx-trio module continuously receives interrupts, it prints a lot of messages which can potentially affect the console output and clutter dmesg logs.
> 
> [Fix]
> This commit calls dev_err_ratelimited() instead of dev_err() to limit the amount of messages.
> 
> [Test Case]
> When TRIO receives a bunch of PIO completion errors or PCIe link disabled errors, a ton of error messages from the IRQ handler can be seen, which has been limited by this patch.
> 
> [Regression Potential]
> Regression potential can be considered minimum since the patch does not change any functions of the driver, but merely makes the error log more readable.
> 
> Shravan Kumar Ramani (1):
>    UBUNTU: SAUCE: mlx-trio: Use rate-limited prints in interrupt handler
> 
>   drivers/platform/mellanox/mlx-trio.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc