ACK: [B][SRU][PATCH 0/1] selftests/net: bump timeout to 5 minutes

[Kleber Souza]

On 05.05.21 08:19, Po-Hsu Lin wrote:
> [Impact]
> These 3 tests will fail with timeout error when running the whole
> "net" test in ubuntu_kernel_selftests:
>    * not ok 12 selftests: net: xfrm_policy.sh # TIMEOUT
>    * not ok 16 selftests: net: pmtu.sh # TIMEOUT
>    * not ok 19 selftests: net: udpgso_bench.sh # TIMEOUT
> 
> They will pass if you run them manually. This is because of the
> default 45 seconds timeout in kselftest framework.
> 
> A quick test shows these tests will take about:
>    xfrm_policy.sh - 2m19.690s
>    pmtu.sh - 3m6.832s
>    udpgso_bench.sh - 0m57.985s
> 
> [Fix]
> * b881d089c7c9c7 ("selftests/net: bump timeout to 5 minutes")
> 
> We have commit 852c8cbf34d3b3 ("selftests/kselftest/runner.sh: Add 45
> second timeout per test") for default timeout added since Bionic.
> 
> However there is a SAUCE patch ("UBUNTU: SAUCE: selftests/net --
> disable timeout") to disable timeout for the net test in newer
> releases. I think we can leave it as-is for the moment unless some
> test is hanging too long because of that.
> 
> Therefore Only Bionic needs this patch, the patch can be applied with
> some context adjustment.
> 
> [Test]
> With this patch applied, these tests should have a chance to finish.
> 
> [Where problems could occur]
> The fix is just for testing tool, no actual impact to real kernel
> functions. If this 5 minutes timeout is not enough, we might still
> seeing this kind of failures in the test report.
> 
> Po-Hsu Lin (1):
>    selftests/net: bump timeout to 5 minutes
> 
>   tools/testing/selftests/net/Makefile | 2 ++
>   tools/testing/selftests/net/settings | 1 +
>   2 files changed, 3 insertions(+)
>   create mode 100644 tools/testing/selftests/net/settings
> 

With the additional comments suggested by Stefan.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

Thanks