NACK/cmt: [SRU][B/gcp-4.15][F/gcp][G/gcp][PATCH 0/1] Set BLK_DEV_NVME=y

[Stefan Bader]

On 06.05.21 07:48, Khalid Elmously wrote:
> On 2021-05-05 10:49:44 , Stefan Bader wrote:
>> On 04.05.21 08:06, Khalid Elmously wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1927050
>>>
>>> Khalid Elmously (1):
>>>     UBUNTU: [config] gcp: enable BLK_DEV_NVME=y
>>>
>>>    debian.gcp-4.15/config/annotations          | 7 +++++--
>>>    debian.gcp-4.15/config/config.common.ubuntu | 4 ++--
>>>    2 files changed, 7 insertions(+), 4 deletions(-)
>>>
>>
>> This changes modules into built-ins, does this not require dropping those
>> from modules lists (abi files)?
> 
> Yes, they need to be dropped from the module list. But doesn't that normally happen during cranking, after start-new-release?

No, before the first build without the module this does not happen. Normally you 
commit the changes which remove the module from the list in the current abi 
files together with the config change. The current abi files get replaced on 
open but if that open commit is then rebased before any new changes, then git is 
clever enough to adjust the module drops to be in the new current abi files.

-Stefan

> 
>>
>> What about hirsute:linux-gcp? Was this change made there already?
> 
> Yes, hirsute should get it too. Will include it in v2
> 
> 
>>
>> -Stefan
>>
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210507/37030c7d/attachment.sig>