NACK/CMT: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: tmfifo: Fix a memory barrier issue

[Kelsey Skunberg]

Hi Liming,

Please also send v2 as its own thread. Same response as I left on your
other patch set "UBUNTU: SAUCE: platform/mellanox: Add ctrl message and 
MAC configuration".

Thank you!

-Kelsey

On 2021-05-05 12:58:27 , Liming Sun wrote:
> BugLink: https://bugs.launchpad.net/bugs/1927262
> 
> SRU Justification:
> 
> [Impact]
> 
> * The virtio framework uses wmb() when updating avail->idx. It guarantees
>   the write order, but not necessarily loading order for the code accessing
>   the memory. So potentially it could cause traffic stuck which has been
>   observed in the field.
> 
> [Fix]
> * This commit adds a load barrier after reading the avail->idx to make sure
>   all the data in the descriptor is visible. It also adds a barrier when
>   returning the packet to virtio framework to make sure read/writes are
>   visible to the virtio code.
> 
> [Test Case]
> * Just normal test. This change doesn't affect any functionality.
> 
> [Regression Potential]
> 
> * This version of the driver was tested by QA/verification for a while so no
>   known regression at the moment.
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team