ACK: [PATCH 1/1][Hirsute][Unstable] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure

[Krzysztof Kozlowski]

On 03/05/2021 17:51, dann frazier wrote:
> From: Marc Zyngier <maz at kernel.org>
> 
> BugLink: https://bugs.launchpad.net/bugs/1925075
> 
> When failing the driver probe because of invalid firmware properties,
> the GTDT driver unmaps the interrupt that it mapped earlier.
> 
> However, it never checks whether the mapping of the interrupt actially
> succeeded. Even more, should the firmware report an illegal interrupt
> number that overlaps with the GIC SGI range, this can result in an
> IPI being unmapped, and subsequent fireworks (as reported by Dann
> Frazier).
> 
> Rework the driver to have a slightly saner behaviour and actually
> check whether the interrupt has been mapped before unmapping things.
> 
> Reported-by: dann frazier <dann.frazier at canonical.com>
> Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver")
> Signed-off-by: Marc Zyngier <maz at kernel.org>
> Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf
> Cc: <stable at vger.kernel.org>
> Cc: Fu Wei <wefu at redhat.com>
> Reviewed-by: Sudeep Holla <sudeep.holla at arm.com>
> Tested-by: dann frazier <dann.frazier at canonical.com>
> Tested-by: Hanjun Guo <guohanjun at huawei.com>
> Reviewed-by: Hanjun Guo <guohanjun at huawei.com>
> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
> Link: https://lore.kernel.org/r/20210421164317.1718831-2-maz@kernel.org
> Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>
> (cherry picked from commit 1ecd5b129252249b9bc03d7645a7bda512747277 linux-next)
> Signed-off-by: dann frazier <dann.frazier at canonical.com>
> ---
>  drivers/acpi/arm64/gtdt.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>


Best regards,
Krzysztof