NAK: [PATCH 1/3] net/tls: Add asynchronous resync

Kleber Souza kleber.souza at canonical.com
Tue May 4 07:39:49 UTC 2021


On 03.05.21 21:38, Daniel Jurgens wrote:
> From: Boris Pismenny <borisp at mellanox.com>
> 
> This patch adds support for asynchronous resynchronization in tls_device.
> Async resync follows two distinct stages:
> 
> 1. The NIC driver indicates that it would like to resync on some TLS
> record within the received packet (P), but the driver does not
> know (yet) which of the TLS records within the packet.
> At this stage, the NIC driver will query the device to find the exact
> TCP sequence for resync (tcpsn), however, the driver does not wait
> for the device to provide the response.
> 
> 2. Eventually, the device responds, and the driver provides the tcpsn
> within the resync packet to KTLS. Now, KTLS can check the tcpsn against
> any processed TLS records within packet P, and also against any record
> that is processed in the future within packet P.
> 
> The asynchronous resync path simplifies the device driver, as it can
> save bits on the packet completion (32-bit TCP sequence), and pass this
> information on an asynchronous command instead.
> 
> Signed-off-by: Boris Pismenny <borisp at mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt at mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm at mellanox.com>
> (cherry picked from commit ed9b7646b06a2ed2450dd9437fc7d1ad2783140c)
> Signed-off-by: Daniel Jurgens <danielj at nvidia.com>


Hello Daniel,

This patchset is missing a few things:
- Cover letter
- Reference to a Launchpad bug report as BugLink
- Which are the impacted kernels (I assume focal/linux-bluefield)

Could you please resend this patchset with the additional information?


Thanks,
Kleber



More information about the kernel-team mailing list