NACK: [PATCH][ Xenial] UBUNTU: Fix CVE-2015-1350 regression

[Thadeu Lima de Souza Cascardo]

Hey, Tim.

Stefan already sent a patch for this.

I will take the chance to do some nitpicks, nonetheless.

The subject should have had "UBUNTU: SAUCE:" instead of simply "UBUNTU:".

On Wed, Mar 31, 2021 at 06:15:04AM -0600, Tim Gardner wrote:
> CVE-2015-1350

Though this fixes the original CVE backports, a bug was reported for this, it
is important that that bug is mentioned in the commit. One good reason for this
is that the release of a kernel with this commit will close the bug, as it will
appear in the changelog.

> 
> Commit b3ce51efc535125aa3bea570467ebe7535975467 ('fuse: Propagate dentry down to inode_change_ok()')
> introduced a regression in fs/fuse/dir.c where fuse_do_setattr() was being
> called with a pointer to an inode structure instead of  a pointer to a dentry structure.
> How did this even compile ?

Lines are too long here.  :-)

I think for SAUCE patches, we can still try to stick with Linux coding style
and use scripts/checkpatch.pl.

Thanks.
Cascardo.

> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  fs/fuse/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 3456f6861293..6413273e42f7 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1769,7 +1769,7 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr)
>  	if (!attr->ia_valid)
>  		return 0;
>  
> -	ret = fuse_do_setattr(inode, attr, file);
> +	ret = fuse_do_setattr(entry, attr, file);
>  	if (!ret) {
>  		/* Directory mode changed, may need to revalidate access */
>  		if (d_is_dir(entry) && (attr->ia_valid & ATTR_MODE))
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team